Skip to content

ERSSUP-86837 - Update AG Create/Update/Convert Docs - #2394

Merged
tobycook1 merged 1 commit into
developfrom
feature/ERSSUP-85961
Aug 21, 2025
Merged

ERSSUP-86837 - Update AG Create/Update/Convert Docs#2394
tobycook1 merged 1 commit into
developfrom
feature/ERSSUP-85961

Conversation

@pca-nhs

@pca-nhs pca-nhs commented Jul 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Routine Change

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

pca-nhs
pca-nhs commented Jul 14, 2025
View reviewed changes
Comment thread specification/components/stu3/schemas/eRS-CreateAdviceAndGuidance-Request-Parameters.yaml Outdated
@tobycook1
tobycook1 marked this pull request as ready for review August 21, 2025 10:25
@tobycook1
tobycook1 requested a review from a team as a code owner August 21, 2025 10:25
@tobycook1
tobycook1 force-pushed the feature/ERSSUP-85961 branch from 0e07601 to ca18021 Compare August 21, 2025 10:37
nhsd-jack-wainwright
nhsd-jack-wainwright reviewed Aug 21, 2025
View reviewed changes

@nhsd-jack-wainwright nhsd-jack-wainwright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍.

@nitishRastogiNHS
nitishRastogiNHS requested review from nitishRastogiNHS and removed request for nitishRastogiNHS August 21, 2025 10:57
@tobycook1
tobycook1 force-pushed the feature/ERSSUP-85961 branch from ca18021 to 1f89b16 Compare August 21, 2025 10:58
nitishRastogiNHS
nitishRastogiNHS approved these changes Aug 21, 2025
View reviewed changes

@nitishRastogiNHS nitishRastogiNHS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pca-nhs @tobycook1
[ERSSUP-86837]-[JW]-[Update AG create update convert docs]-[PCA]
a139ed0 
[ERSSUP-85961]-[JW]-[Review corrections]-[PCA]
@tobycook1
tobycook1 force-pushed the feature/ERSSUP-85961 branch from 1f89b16 to a139ed0 Compare August 21, 2025 12:12
@tobycook1
tobycook1 merged commit 1ae8602 into develop Aug 21, 2025
4 checks passed
@tobycook1
tobycook1 deleted the feature/ERSSUP-85961 branch August 21, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@nhsd-jack-wainwright nhsd-jack-wainwright nhsd-jack-wainwright left review comments
@nitishRastogiNHS nitishRastogiNHS nitishRastogiNHS approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pca-nhs @nhsd-jack-wainwright @nitishRastogiNHS @tobycook1